Calculate the distance between two points has been submitted for review

Under review by Picture of Christian Lawson-Perfect Christian Lawson-Perfect

Needs attention from the submitter

Submission note

Submitted by Elizabeth Petrie


Checklist


Comments

Comment

Picture of Christian Lawson-Perfect

Christian Lawson-Perfect commented 1 year, 11 months ago

  • Licence: Please set the licence to CC-BY. At the moment it's CC-BY-SA.
  • Metadata: The name should describe the activity, not the topic covered. "Calculate the distance between two points on a sphere, given their latitude and longitude" would do.
  • Metadata: We need a context tag for "Geospatial science" or "Spatial science" .
  • Text:
    • I would put the point lat and longs in a table
    • I'm not sure about the para at the top, about adaptive marking. It might be that in the future the interface automatically tells you when adaptive marking is set up.
    • The sin and cos in the advice need to be \sin and \cos to be rendered correctly.
    • Is n $n$ or $N$?
    • A generic diagram in the advice would be very helpful, but isn't a blocker.
  • Marking:
    • There's a margin of ± 1 degree on part a, which isn't mentioned. This should be mentioned in the question description. What kind of mistake do you imagine would lead to this being needed? Maybe it would be better to have an alternative catching the ±1 degree, with a suggestion to check rounding.
    • And a margin of ±10 km on part b.
    • Should "require trailing zeros" be turned on? Without it, I can give fewer than 4 decimal places in part a, and there's no penalty.
    • There are no unit tests.
  • Advice:
    • The advice could do with being a bit more explicit, ideally laid out with LaTeX \align: show the formula, and the numbers subbed into the formula, and then the result.
    • Headers for each part's advice would make it easier to read
    • A line before the formula $\cos(n) = \ldots$ explaining its meaning
  • Variables:
    • The variable side_n_deg is rounded off. The number entry part's precision restriction will do the rounding, so this could cause unexpected problems.
    • side_n_rad needs a description containing the formula in LaTeX and an explanation

Mikel Artester commented 1 year, 11 months ago

I'm reviewing this.